Bug: Emit doesn't update 2 way bound props #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandi95
commented
Feb 16, 2021
| @@ -82,4 +83,32 @@ describe('props', () => { | |||
| object: {} | |||
| }) | |||
| }) | |||
|
|
|||
| it('should return the updated props on 2 way binding', async () => { | |||
There was a problem hiding this comment.
This file is probably the wrong place for this test, please advise where it would be best.
There was a problem hiding this comment.
Here is probably fine. Probably could re-think the test layout at some point.
nandi95
commented
Feb 16, 2021
| @@ -48,7 +48,7 @@ function recordEvent( | |||
| events: Events, | |||
| vm: ComponentInternalInstance, | |||
| event: string, | |||
| args: Events[number] | |||
| args: unknown[] | |||
There was a problem hiding this comment.
This I typed wrong in the previous PR, fixed here
nandi95
commented
Feb 17, 2021
lmiller1990
approved these changes
Feb 17, 2021
|
We may revisit and revert this @nandi95. Based on #440 (comment) In that case, you'd need to just change to use a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.